Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] added missing default value #4267

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[docs] added missing default value #4267

merged 1 commit into from
Jul 28, 2020

Conversation

ChristianCoenen
Copy link
Contributor

Proposed change(s)

Added missing default value for the parameter num_epoch to the documentation.
According to the source code, the default value is 3:
Link to the source code file (default value in line 114)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@awjuliani awjuliani self-requested a review July 28, 2020 01:30
@awjuliani awjuliani self-assigned this Jul 28, 2020
awjuliani
awjuliani approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@awjuliani awjuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Thanks for making it, @ChristianCoenen!

@awjuliani awjuliani merged commit 6e0675d into Unity-Technologies:master Jul 28, 2020
@ChristianCoenen ChristianCoenen deleted the docs_default_value_missing branch July 28, 2020 21:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awjuliani awjuliani awjuliani approved these changes

Assignees

@awjuliani awjuliani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianCoenen @awjuliani