Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify support for external trainers or inference #4286

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Jul 30, 2020

Proposed change(s)

Update docs to clarify that we don't provide support for externally trained models, and we don't provide support for running our models outside of Unity.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested review from shihzy and mmattar July 30, 2020 01:01
Copy link

@mmattar mmattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@@ -45,3 +42,22 @@ use for Inference.
**Note:** For most of the models generated with the ML-Agents Toolkit, CPU will
be faster than GPU. You should use the GPU only if you use the ResNet visual
encoder or have a large number of agents with visual observations.

# Unsupported systems
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Systems may be too broad. One alternative (that I don't love) is "Unsupported Workflows"

@chriselion chriselion merged commit 9d92e8a into master Aug 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the model-support-policy branch August 5, 2020 16:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants