Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5 -> Master #4291

Merged
merged 7 commits into from
Jul 31, 2020
Merged

Release 5 -> Master #4291

merged 7 commits into from
Jul 31, 2020

Conversation

awjuliani
Copy link
Contributor

Proposed change(s)

Merges changes from release 5 branch into master.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably decide how to update the changelog to reflect that the fixes went out in this release, but that's going annoying because we didn't bump the package version...

@awjuliani
Copy link
Contributor Author

@chriselion Any suggestion? Should I hold this PR until adding the changes to the changelog?

@chriselion
Copy link
Contributor

I think just merge this. we can try to fix the changelog on master.

@awjuliani awjuliani merged commit e36379d into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the r5-master branch July 31, 2020 21:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awjuliani @chriselion @vincentpierre @andrewcoh