Clean up AcademyFixedUpdateStepper when playmode changed #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Oct 2, 2020
chriselion
reviewed
Oct 2, 2020
chriselion
reviewed
Oct 7, 2020
| @@ -32,7 +32,14 @@ internal class AcademyFixedUpdateStepper : MonoBehaviour | |||
| { | |||
| void FixedUpdate() | |||
| { | |||
| Academy.Instance.EnvironmentStep(); | |||
| if (!Academy.IsStepperOwner(this)) | |||
There was a problem hiding this comment.
I think you should be a little more careful here with how you access the Academy instance so that we don't create a new one accidentally. I'd recommend:
- Make IsStepperOwner() non-static again
- In FixedUpdate(), either do nothing if the Academy isn't initialized, or call Destroy() (but avoid the call to IsStepperOwner).
chriselion
reviewed
Oct 7, 2020
| @@ -32,7 +32,14 @@ internal class AcademyFixedUpdateStepper : MonoBehaviour | |||
| { | |||
| void FixedUpdate() | |||
| { | |||
| Academy.Instance.EnvironmentStep(); | |||
| if (!Academy.IsStepperOwner(this)) | |||
There was a problem hiding this comment.
Also, can you add some comments on why this is necessary?
* run devproject tests * loosen trigger for testing * reset Academy at start of test * redo trigger, add comment
…chnologies/ml-agents into develop-cleanup-stepper
chriselion
reviewed
Oct 7, 2020
chriselion
approved these changes
Oct 7, 2020
Co-authored-by: Chris Elion <chris.elion@unity3d.com>
Updated in the summary |
dongruoping
added a commit
that referenced
this pull request
Nov 10, 2020
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Clean up AcademyFixedUpdateStepper when playmode changed. Also add insurance check in stepper to delete itself if it's not the stepper of current Academy.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Fixing issue reported in #4521 .
JIRA ticket: https://jira.unity3d.com/browse/MLA-1410
Types of change(s)
Checklist
Other comments