Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Editor Analytics for inference #4677

Merged
merged 27 commits into from
Dec 15, 2020
Merged

In-Editor Analytics for inference #4677

merged 27 commits into from
Dec 15, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Nov 19, 2020 •
edited
Loading

Proposed change(s)

Adds analytics tracking for inference. These are only sent when running inference in the editor, do not collect any PII beyond what Unity already collects in its base events, and can be opting out of other Unity Editor analytics will disable these too.

More detailed readme with opt-out information coming soon

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion commented Nov 20, 2020
View reviewed changes
com.unity.ml-agents/Runtime/Analytics/InferenceAnalytics.cs

static bool EnableAnalytics()
{
if (s_EventRegistered)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adapted from the example here (internal link)

@chriselion chriselion marked this pull request as ready for review December 5, 2020 01:47
surfnerd
surfnerd approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@surfnerd surfnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you messaged me privately about adding code to allow for opting out of sending analytics. Please remove the FNV Hash code if you are going to use the Hash128 code path instead.

@chriselion
Copy link
Contributor Author

After investigating options, we won't be adding a separate opt-out for analytics; users will be able to use the existing options to opt out from all events. This will be clarified in a README soon.

shihzy
shihzy approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@shihzy shihzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legal language LGTM.

@chriselion chriselion merged commit 258f4dc into master Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the MLA-1545-inference-analytics branch December 15, 2020 17:10
chriselion pushed a commit that referenced this pull request Dec 15, 2020
In-Editor Analytics for inference (#4677)
49090d0
@chriselion chriselion mentioned this pull request Dec 15, 2020
Merged
10 tasks
chriselion pushed a commit that referenced this pull request Dec 15, 2020
In-Editor Analytics for inference (#4677) (#4758)
b1ddc80
@chriselion chriselion mentioned this pull request Jan 29, 2021
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NielsUnity3d NielsUnity3d NielsUnity3d left review comments

@shihzy shihzy shihzy approved these changes

@surfnerd surfnerd surfnerd approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chriselion @surfnerd @vincentpierre @shihzy @NielsUnity3d