[MLA-1587] Don't warn about minor version mismatch, add links in specific messages #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2020 17:14
surfnerd
approved these changes
Dec 14, 2020
dongruoping
approved these changes
Dec 14, 2020
vincentpierre
approved these changes
Dec 14, 2020
chriselion
pushed a commit
that referenced
this pull request
Dec 15, 2020
…ific messages (#4688) * Don't warn about minor version mismatch, add links in specific messages * changelog * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
The current warnings about minor version mismatches are a bit noisy, and we already have warnings in place when a user tries to use a feature in Unity that isn't supported by the trainer. So just remove the warnings (and move some information to the specific warning messages)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1587
Types of change(s)
Checklist
Other comments