Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staging tests #4708

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Conversation

andrewcoh
Copy link
Contributor

Proposed change(s)

Fixing some tests that broke because of the clipping action changes.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@@ -78,8 +78,6 @@ def _sample_action(self, dists: DistInstances) -> AgentAction:
# This checks None because mypy complains otherwise
if dists.continuous is not None:
continuous_action = dists.continuous.sample()
if self._clip_action_on_export:
Copy link
Contributor Author

@andrewcoh andrewcoh Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just an accident and wrong

@andrewcoh andrewcoh merged commit 5a87625 into develop-hybrid-action-staging Dec 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-staging-tests branch December 4, 2020 16:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant