Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constructing action proto for gail test #4723

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix constructing action proto for gail test #4723

merged 1 commit into from
Dec 8, 2020

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

Describe the changes made in this PR.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

andrewcoh
andrewcoh approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass :shipit:

@dongruoping
Copy link
Contributor Author

Gail tests passed.
The two failed tests are simple_rl tests that didn't reached the goal reward, which we should fix in staging.

@dongruoping dongruoping merged commit 6156ecf into develop-hybrid-action-staging Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-hybrid-gail-test branch December 8, 2020 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh andrewcoh approved these changes

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongruoping @chriselion @andrewcoh