Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Reduce dimension of continuous entropy coefficient #4725

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[refactor] Reduce dimension of continuous entropy coefficient #4725

merged 1 commit into from
Dec 9, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Dec 8, 2020

Proposed change(s)

For hybrid-SAC, we were storing an entropy coefficient per continuous action. We just need to store one for all continuous actions.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from andrewcoh December 8, 2020 23:34
@ervteng ervteng merged commit a2c419d into develop-hybrid-action-staging Dec 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-reducedimentcoef branch December 9, 2020 04:31
@chriselion chriselion mentioned this pull request Dec 9, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh andrewcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @andrewcoh