Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Action in BrainParameter drawers, Update tutorial docs #4748

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

Describe the changes made in this PR.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you mind updating this screenshot too?
https://github.com/Unity-Technologies/ml-agents/blob/master/docs/images/3dball_learning_brain.png

Not sure if there are any others of the Brain Parameters...

@dongruoping
Copy link
Contributor Author

dongruoping commented Dec 14, 2020

Not sure if there are any others of the Brain Parameters...

Did a quick scan through all images and updated all that I found

@dongruoping dongruoping merged commit 7deb8eb into master Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-rename-actions branch December 15, 2020 18:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants