Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --results-dir #5269

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Fix --results-dir #5269

merged 3 commits into from
Apr 15, 2021

Conversation

dongruoping
Copy link
Contributor

@dongruoping dongruoping commented Apr 15, 2021 •
edited
Loading

Proposed change(s)

Reported in #5268.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Sorry, didn't realize this was necessary, and my fault for not adding a test.

@dongruoping dongruoping merged commit 29810c4 into main Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-fix-result-dir branch April 15, 2021 20:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongruoping @chriselion