Run package tests with warn-as-error #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Apr 19, 2021
| @@ -33,7 +33,7 @@ test_coverage_{{ package.name }}_{{ platform.name }}_{{ editor.version }}: | |||
| {% if package.name == "com.unity.ml-agents.extensions" %} | |||
| pull_request.changes.any match "com.unity.ml-agents.extensions/**" OR | |||
| {% endif %} | |||
| pull_request.changes.any match ".yamato/com.unity.ml-agents-test.yml") | |||
| pull_request.changes.any match ".yamato/com.unity.ml-agents-coverage.yml") | |||
There was a problem hiding this comment.
This was triggering even though it wasn't supposed to (now it's triggering because it was modified).
surfnerd
approved these changes
Apr 19, 2021
chriselion
pushed a commit
that referenced
this pull request
Apr 19, 2021
1 task
chriselion
pushed a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
We're running
upm-ci project testin the coverage job, so I think we can go back to just running the package tests in this job (assuming we didn't need this for the way we pack). Add--warnings-as-errorshere to catch warnings that would appear in the package.Types of change(s)