Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mla 2205 separate schedule lr beta epsilon #5538

Merged
merged 16 commits into from
Sep 30, 2021
Merged

Feature/mla 2205 separate schedule lr beta epsilon #5538

merged 16 commits into from
Sep 30, 2021

Conversation

miguelalonsojr
Copy link
Collaborator

@miguelalonsojr miguelalonsojr commented Sep 16, 2021 •
edited by maryamhonari
Loading

Proposed change(s)

Added support for separate schedules for learning rate, beta, and epsilon.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@miguelalonsojr miguelalonsojr force-pushed the feature/MLA-2205-separate_schedule_lr_beta_epsilon branch 2 times, most recently from b022223 to ebad8ab Compare September 17, 2021 19:50
@miguelalonsojr miguelalonsojr force-pushed the feature/MLA-2205-separate_schedule_lr_beta_epsilon branch from ebad8ab to 715e4dd Compare September 17, 2021 20:18
dongruoping
dongruoping reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@dongruoping dongruoping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add it to changelog
  2. Optional: is there any example environment that can benefit from this? It would be great if we can actually train and test the effectiveness and put that as example for users

docs/Training-Configuration-File.md Outdated Show resolved Hide resolved
ml-agents/mlagents/trainers/settings.py Outdated Show resolved Hide resolved
dongruoping
dongruoping reviewed Sep 20, 2021
View reviewed changes
com.unity.ml-agents/CHANGELOG.md Outdated Show resolved Hide resolved
docs/Training-Configuration-File.md Outdated Show resolved Hide resolved
docs/Training-Configuration-File.md Outdated Show resolved Hide resolved
maryamhonari
maryamhonari reviewed Sep 29, 2021
View reviewed changes
ml-agents/mlagents/trainers/settings.py Outdated Show resolved Hide resolved
docs/Training-Configuration-File.md Outdated Show resolved Hide resolved
@miguelalonsojr miguelalonsojr merged commit f2e0cb8 into main Sep 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/MLA-2205-separate_schedule_lr_beta_epsilon branch September 30, 2021 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryamhonari maryamhonari maryamhonari approved these changes

@andrewcoh andrewcoh Awaiting requested review from andrewcoh

@dongruoping dongruoping Awaiting requested review from dongruoping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miguelalonsojr @maryamhonari @dongruoping @andrewcoh