Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotnet 8.x in pre-commits to fix flaky failures #6083

Merged
merged 1 commit into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Use dotnet 8.x in pre-commits to fix flaky failures

    The 8.x release should contain dotnet/runtime#90342 which fixes dotnet/runtime#80619.
    
    I hope this will fix flaky failures like https://github.com/Unity-Technologies/ml-agents/actions/runs/8268945605/job/22623023348 of the form:
    ```
    dotnet-format............................................................Failed
    - hook id: dotnet-format
    - exit code: 1
    
    System.IO.IOException: The system cannot open the device or file specified. : 'NuGet-Migrations'
       at System.Threading.Mutex.CreateMutexCore(Boolean initiallyOwned, String name, Boolean& createdNew)
       at System.Threading.Mutex..ctor(Boolean initiallyOwned, String name)
       at NuGet.Common.Migrations.MigrationRunner.Run(String migrationsDirectory)
       at Microsoft.DotNet.Configurer.DotnetFirstTimeUseConfigurer.Configure()
       at Microsoft.DotNet.Cli.Program.ConfigureDotNetForFirstTimeUse(IFirstTimeUseNoticeSentinel firstTimeUseNoticeSentinel, IAspNetCertificateSentinel aspNetCertificateSentinel, IFileSentinel toolPathSentinel, Boolean isDotnetBeingInvokedFromNativeInstaller, DotnetFirstRunConfiguration dotnetFirstRunConfiguration, IEnvironmentProvider environmentProvider, Dictionary`2 performanceMeasurements)
       at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient)
       at Microsoft.DotNet.Cli.Program.Main(String[] args)
    ```
    alex-mccarthy-unity committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d2eecb6 View commit details
    Browse the repository at this point in the history