Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for zh-CN #11

Merged
merged 17 commits into from
Apr 11, 2024
Merged

Docs for zh-CN #11

merged 17 commits into from
Apr 11, 2024

Conversation

kuolemax
Copy link
Contributor

@kuolemax kuolemax commented Apr 9, 2024

Applicable Changes

  • Feature addition
  • Modification to behaviour of existing functionality (potential breaking change)
  • Modification to existing public APIs (potential breaking change)
  • Bug fix
  • User docs modification
  • Rust toolchain updates
  • Dependency updates
  • Workflow change (GitHub Actions)
  • Repository housekeeping (e.g. READMEs, licensing, templates, etc.)

Related Issues

N/A

Description of Changes

Add i18n support and add zh-CN docs

Testing Instructions

Check-list

  • I have updated or added to the user docs where applicable
  • I have tested the changes on real hardware if applicable
  • The changes do not break compilations with other potentially related feature flags
  • Credit given where applicable

Copy link
Owner

@Univa Univa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to provide these translations :)

Before I merge this in, do you mind moving the english translations back out, instead of having them in /en? This causes the default version of the docs to have a /en in the URL, which I'd like to avoid if possible. To fix this, it would be better to use a root locale for the english translation instead.

@kuolemax
Copy link
Contributor Author

kuolemax commented Apr 11, 2024

Ok, I have moved en to root, now the default document URL does not contain /en

@Univa Univa merged commit 2fa47dc into Univa:main Apr 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants