Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding space to status code when 403 #55

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

Yoroitchi
Copy link
Contributor

This pull request aims to solve #54

@vladimir-mencl-eresearch
Copy link
Collaborator

Thanks for the PR!

The space at the end of the string looks a bit off...

The status values (of type String) are in the end passed to and processed by the satosa.response.Response class - which in values defined internally use the syntax "<code> <reason>" - e.g., "404 Not Found" - see https://github.com/IdentityPython/SATOSA/blob/master/src/satosa/response.py#L95-L112

How about using "403 Forbidden" in this case? It would make it clear why the space is there - and would match the use that already exists in SATOSA.

Cheers,
Vlad

Add Corresponding message to status code to make it clearer
@vladimir-mencl-eresearch
Copy link
Collaborator

Thanks for the change @Yoroitchi . Looks like an easy fix good to merge to me @peppelinux

@Yoroitchi
Copy link
Contributor Author

Hello @vladimir-mencl-eresearch,
Thank you for your review i did the changes following your advice.

@peppelinux peppelinux merged commit f626481 into UniversitaDellaCalabria:main Sep 12, 2024
@peppelinux
Copy link
Member

Thank you @Yoroitchi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants