fix: year bugs and some hardcoding

UniversityOfHelsinkiCS · Jan 3, 2025 · 0530637 · 0530637
1 parent be9882a
commit 0530637
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/staging.yml b/.github/workflows/staging.yml
@@ -27,8 +27,6 @@ jobs:
             evaluation,
             metaevaluation,
             homepage,
-            trackingpage,
-            facultymonitoringoverview,
           ]
     name: Run tests
     runs-on: ubuntu-latest

diff --git a/client/components/FacultyMonitoringView/FacultyMonitoringOverview/MonitoringOverview.js b/client/components/FacultyMonitoringView/FacultyMonitoringOverview/MonitoringOverview.js
@@ -51,15 +51,13 @@ const MonitoringOverview = ({ t, lang, faculties }) => {
     [faculties, lang],
   )
 
+  // hard coded for this form to get year 2024 answers
   useEffect(() => {
     setRadioFilter('all')
-    dispatch(getAllTempAnswersAction())
-    if (!answers) {
-      dispatch(getTempAnswersAfterDeadline(formKeys.FACULTY_MONITORING, year))
-    }
+    dispatch(getTempAnswersAfterDeadline(formKeys.FACULTY_MONITORING, year))
   }, [selectedLevel])
 
-  if (!answers) return <Loader active />
+  if (!answers || !faculties) return <Loader active />
 
   const getAnswer = (part, faculty) => {
     const answer = answers.find(a => a.programme === faculty)

diff --git a/client/components/OverviewPage/ColorTable.js b/client/components/OverviewPage/ColorTable.js
@@ -123,7 +123,7 @@ const ColorTable = React.memo(
 
     useEffect(() => {
       dispatch(getAllTempAnswersAction())
-      if (form !== formKeys.META_EVALUATION) dispatch(getAnswersActionAll())
+      dispatch(getAnswersActionAll())
       if (isAdmin(currentUser)) dispatch(getProgrammeOwners())
     }, [])