Tau changez #1250
Merged
Tau changez #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion data) Added workload options to config (relating to production data)
…lautteenantajien-naeyttaemisen-asetuksiin-liittyen to development Pull request created in: https://leanware.atlassian.net/browse/TAUKPJ-168 by the Git Integration for Jira app.
…ind of SISU-links are shown to users -Added USE_ROLE_BASED_COURSE_LINKS related links and their use to courseSummary page -Modified /course-units/:code endpoint on the backend to return isTeacher information in addition to the data it already returned -Link text modifications for tau
…g of automatic reminder emails to students
…inkki väärin -Added a new setting USE_ROLE_BASED_COURSE_LINKS that controls what kind of SISU-links are shown to users -Added USE_ROLE_BASED_COURSE_LINKS related links and their use to courseSummary page -Modified /course-units/:code endpoint on the backend to return isTeacher information in addition to the data it already returned -Link text modifications for tau
… node heap Updated Dockerfile
Updated Dockerfile
…aksi Uudelleennimetty tiedostoja, mikä sotkee comparea: Footer-default = HYn footer (kopio hy:n masterista) Footer-tau = TAUn footer (kopio devistä, poistettu käyttämätöntä koodia) Footer = komponentti, mikä valitsee näytettävän footerin
Fixed course links to be compatible with both HY and TAU
# Conflicts: # src/client/util/common.js
…git/tuni-kpj into hy-vienti-2024-03-26
Default value removed from NO_USER_USERNAME
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Veikkosuhonen
commented
Apr 16, 2024
package.json
Outdated
| "test": "npm run test:setup && sleep 10 && npm run test:e2e", | ||
| "start:dev": "npm run build && NODE_ENV=development concurrently -k \"npx tsc --project src/server/tsconfig.json --watch\" \"nodemon --inspect=0.0.0.0 -L ./build/server/index.js\" \"CHOKIDAR_USEPOLLING=true react-app-rewired start\"", |
There was a problem hiding this comment.
npm run build at the start seems like a mistake. Without it, everything worked fine.
There was a problem hiding this comment.
import('../config...') does not compile:
Error: Can't resolve '../config' in '/usr/src/app/src/client/hooks'
Even though it never runs because configName = null by default, webpack apparently tries to resolve the import and fails.
| background: theme => theme.palette.primary.dark, | ||
| boxShadow: theme => `0px 0px 10px 1px ${theme.palette.primary.main}`, | ||
| background: theme => theme.palette.primary.main, | ||
| boxShadow: theme => `0px 0px 6px 1px #aaa`, | ||
| borderRadius: 0, |
There was a problem hiding this comment.
Why are the colours being changed? Maybe this wasnt supposed to ship?
… custom theme file
…ntend-ongelma-validoinnissa to development Pull request created in: https://leanware.atlassian.net/browse/TAUKPJ-267 by the Git Integration for Jira app.
* poistettu npm run build hy:n toiveiden mukaan * lisätty config -kansioon example-custom-ui.js, joka viedään hy:lle (pitäisi auttaa import-ongelmaan) * vaihdettu taun teemaan primary-paletin dark samaksi kuin main (tumma violetti), sillä dark-väriä ei näyttäisi olevan käytössä kuin otsikkopalkissa ja vähäpätöisessä roolissa tabien linkin korostuksissa, missä tumma violetti toimii myös.
…alaute into virkistys-2024-04-22
…git/tuni-kpj into hy-vienti-20240422
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.