Get one fbt query perf #1464
Merged
Get one fbt query perf #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veikkosuhonen
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes slow performance when fetching
/api/feedback-targets/:id.This is critical because the endpoint could sometimes be so slow it timed out and returned an error view to the user.
This was caused by changes in #1428 , there was an expensive join to
summariesbyfeedback_target_idwithout an index.In addition, joining
user_feedback_targetsin a single query was expensive.Tested on a local machine with a fbt with around 150/200 feedbacks:
Before: 4000 ms
Adding an index: 800 ms
Separate query for ufbts: 100 ms