Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hSupportsANSIColor #75

Merged
merged 2 commits into from
Jan 3, 2019
Merged

added hSupportsANSIColor #75

merged 2 commits into from
Jan 3, 2019

Conversation

fommil
Copy link
Contributor

@fommil fommil commented Dec 21, 2018

The first part of UnkindPartition/tasty#233

@mpilgrem
Copy link
Collaborator

Please see Contributing.mdand the objective of a high degree of backwards compatibility. The CI checks suggest this PR does not work on Windows or for GHC versions before 8.4.3 on Unix-like systems.

@fommil
Copy link
Contributor Author

fommil commented Dec 22, 2018

Of particular note is that, before GHC 7.10.1 and base-4.8.0.0, <$> was not exported by the Prelude.

heh. Ok, I'll update.

@fommil
Copy link
Contributor Author

fommil commented Dec 22, 2018

@mpilgrem it's looking healthier now...

@mpilgrem
Copy link
Collaborator

mpilgrem commented Dec 22, 2018

I think the problem with the Windows version is that, unlike modules System.Console.ANSI.Unix and System.Console.ANSI.Windows.Emulator, module System.Console.ANSI.Windows does not already import System.Environment (getEnvironment).

@fommil
Copy link
Contributor Author

fommil commented Dec 24, 2018

@mpilgrem green lights in Windows, thanks for your guidance 😄

@fommil
Copy link
Contributor Author

fommil commented Jan 3, 2019

@mpilgrem @feuerbach happy new year! and happy green lights 😃

@mpilgrem
Copy link
Collaborator

mpilgrem commented Jan 3, 2019

Happy New Year! I have a minor request - can this commit not bump the version number or the CHANGELOG. We prefer to do that when we cut a new release for Hackage.

@fommil
Copy link
Contributor Author

fommil commented Jan 3, 2019

done

@mpilgrem mpilgrem merged commit 702bfc4 into UnkindPartition:master Jan 3, 2019
@fommil fommil deleted the emacs-color branch January 3, 2019 23:49
@fommil
Copy link
Contributor Author

fommil commented Jan 3, 2019

thank you for merging!

What is your preferred way to be hassled about cutting a new release? 😊

@mpilgrem
Copy link
Collaborator

mpilgrem commented Jan 4, 2019

There is a new release (a major version bump) coming at the end of Jan 2019, as a consequence of the API changes that started with 0.8.2. As that is relatively soon, I was planning for it to be the next release.

@fommil
Copy link
Contributor Author

fommil commented Jan 4, 2019

thanks for letting me know... I can continue using local overrides until then, an utterly awesome feature of Cabal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants