Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleReporter: force flushing of stdout after showCursor #436

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Bodigrim
Copy link
Collaborator

I don't think I can write a test for this, but I have a persistent problem with some massive test suites when killing application with Ctrl+C leaves a terminal cursor hidden. I verified manually that flushing stdout fixes the issue.

Copy link
Collaborator

@VictorCMiraldo VictorCMiraldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if there's no tests, I don't think a call to hFlush stdout would be harmful here anyway! 👍

@Bodigrim Bodigrim merged commit 7d61d98 into master Nov 27, 2024
14 checks passed
@Bodigrim Bodigrim deleted the flush-showCursor branch November 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants