fix: don't change the "FeatureEnabled" state of the fallback variant

client.go

@@ -418,13 +418,8 @@ func (uc *Client) getVariantWithoutMetrics(feature string, options ...VariantOpt
 
 	getFallbackVariant := func(featureEnabled bool) *api.Variant {
 		if opts.variantFallbackFunc != nil {
-			variant := opts.variantFallbackFunc(feature, ctx)
-			if variant != nil {
-				variant.FeatureEnabled = featureEnabled
-			}
-			return variant
+			return opts.variantFallbackFunc(feature, ctx)
 		} else if opts.variantFallback != nil {
-			opts.variantFallback.FeatureEnabled = featureEnabled
 			return opts.variantFallback
 		}
 

client_test.go

@@ -1192,7 +1192,6 @@ func TestGetVariantWithFallbackVariantWhenFeatureDisabled(t *testing.T) {
 
 	fallbackVariant := api.Variant{
 		Name: "fallback-variant",
-                FeatureEnabled: true,
 	}
 
 	variant := client.GetVariant(feature, WithVariantFallback(&fallbackVariant))
@@ -1261,14 +1260,13 @@ func TestGetVariantWithFallbackVariantWhenFeatureEnabledButNoVariants(t *testing
 
 	fallbackVariant := api.Variant{
 		Name: "fallback-variant",
-                FeatureEnabled: false,
 	}
 
 	variant := client.GetVariant(feature, WithVariantFallback(&fallbackVariant))
 
 	assert.False(variant.Enabled)
 
-	assert.True(variant.FeatureEnabled)
+	assert.False(variant.FeatureEnabled)
 
 	assert.Equal(fallbackVariant, *variant)
 
@@ -1318,7 +1316,6 @@ func TestGetVariantWithFallbackVariantWhenFeatureDoesntExist(t *testing.T) {
 
 	fallbackVariant := api.Variant{
 		Name: "fallback-variant",
-                FeatureEnabled: true,
 	}
 
 	variant := client.GetVariant(feature, WithVariantFallback(&fallbackVariant))