#118 Add IsFeatureEnabled function to client #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…already been retrieved.
There was a problem hiding this comment.
@courupteddata Could you add a section to the readme in this PR on how to use this new functionality?
|
@FredrikOseberg I've added a readme entry for this change. |
FredrikOseberg
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
LGTM. Thanks for your contribution and patience @courupteddata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This change adds an IsFeatureEnabled function that is a variant of the IsEnabled function but accepts a api.Feature instead of a string for the case where you already have the feature.
Closes #118
Discussion points
I'm not certain on the function name and don't want to cause confusion, but I thought it made sense.
I think this functionality could make sense for others and if there is a better approach someone else wants I'm all ears. 👂