fix: flexible-rollout random stickiness is not random enough #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to get skew when we only pick numbers between 0 and 100.
gardleopard
approved these changes
Jan 17, 2023
This was referenced Sep 19, 2024
Merged
thomasheartman
added a commit
to Unleash/unleash-client-go
that referenced
this pull request
Sep 19, 2024
Relates to a related fix done in some other sdks, such as the node one at Unleash/unleash-client-node#417 In this case, this method appears unused, so we can remove it.
thomasheartman
added a commit
to Unleash/unleash-client-go
that referenced
this pull request
Sep 19, 2024
Relates to a related fix done in some other sdks, such as the node one at Unleash/unleash-client-node#417 In this case, the comment was misleading, so we can edit it.
thomasheartman
added a commit
to Unleash/unleash-client-ruby
that referenced
this pull request
Sep 20, 2024
… stickiness id (#200) Same fix as done in some other sdks, such as the node one at Unleash/unleash-client-node#417 Fixes an issue where 1% rollout would not yield any results with random rollout for certain group ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to get skew when we only pick numbers between 0 and 100.