Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow basic parameters to be late bound #201

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

RikudouSage
Copy link
Collaborator

Description

This PR allows the three mandatory parameters to be passed as Stringable objects. Those can be used anywhere a string is expected. The advantage is that the __toString() can be resolved at the time of casting to whatever is necessary, like dynamic environment variable.

Relates to Unleash/unleash-client-symfony#66

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage requested a review from sighphyre April 16, 2024 10:57
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty cool actually

LGTM

@RikudouSage RikudouSage merged commit 603e982 into main Apr 16, 2024
11 checks passed
@RikudouSage RikudouSage deleted the feat/late-bound-parameters branch April 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants