Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: URL appending tweaks #206

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Fix: URL appending tweaks #206

merged 4 commits into from
Jun 25, 2024

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Jun 24, 2024 •
edited
Loading

Description

Fixes support for query parameters in URLs.

Depends on #207

Fixes #205

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage mentioned this pull request Jun 24, 2024
Closed
@RikudouSage RikudouSage requested a review from sighphyre June 24, 2024 14:25
sighphyre
sighphyre approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good, nice one!

@RikudouSage RikudouSage merged commit b149325 into main Jun 25, 2024
12 checks passed
@RikudouSage RikudouSage deleted the fix/url-appending branch June 25, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

403 in PHP SDK when passing prefix or tags in the URL
2 participants
@RikudouSage @sighphyre