Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Calling array_is_list on older versions of php #67

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix: Calling array_is_list on older versions of php #67

merged 1 commit into from
Apr 7, 2022

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Apr 7, 2022 •
edited
Loading

Description

Adds polyfill for array_is_list()

Fixes #66

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage merged commit 933aec2 into main Apr 7, 2022
@RikudouSage RikudouSage deleted the fix/array-is-list branch April 7, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 1.3.172 php7.2 compatibility issue for AbstractListOperatorValidator
1 participant
@RikudouSage