Skip to content

Commit

Permalink
Change logging if no feature flags are returned from server (#200)
Browse files Browse the repository at this point in the history
* Reduce level and reword message if no features are returned from server (whether 304 or error).

* Update changelog.
  • Loading branch information
ivanklee86 authored Apr 2, 2022
1 parent aafb389 commit 4c7bc98
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## v5.1.2
* (Bugfix) Clarify logging if Unleash server doesn't return feature provisioning (i.e. HTTP 304).

## v5.1.1
* (Minor) Move UnleashClient logging to the `UnleashClient` logger.
* (Bugfix) Fix logging for UnleashClient.
Expand Down
2 changes: 1 addition & 1 deletion UnleashClient/periodic_tasks/fetch_and_load.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def fetch_and_load_features(url: str,
if feature_provisioning:
cache.set(FEATURES_URL, feature_provisioning)
else:
LOGGER.warning("Unable to get feature flag toggles, using cached provisioning.")
LOGGER.debug("No feature provisioning returned from server, using cached provisioning.")

if etag:
cache.set(ETAG, etag)
Expand Down

0 comments on commit 4c7bc98

Please sign in to comment.