Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage.rst on default_value #207

Merged
merged 1 commit into from
May 9, 2022
Merged

Update usage.rst on default_value #207

merged 1 commit into from
May 9, 2022

Conversation

inirudebwoy
Copy link
Contributor

Update documentation on how to set default value.

Description

I have update documentation on default value.

Fixes # (issue)

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@inirudebwoy
Update usage.rst
e98845e 
Update documentation on how to set default value.
FredrikOseberg
FredrikOseberg approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@FredrikOseberg
Copy link
Collaborator

Github PR: Python docs contribution

ivanklee86
ivanklee86 approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@ivanklee86 ivanklee86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I completely forgot about this. 😭

@ivanklee86 ivanklee86 merged commit 72a1ce4 into Unleash:main May 9, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.089% when pulling e98845e on inirudebwoy:patch-1 into 576d4ad on Unleash:main.

@inirudebwoy inirudebwoy mentioned this pull request May 10, 2022
Closed
@thomasheartman thomasheartman mentioned this pull request May 19, 2022
Merged
9 tasks
@thomasheartman thomasheartman mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

@ivanklee86 ivanklee86 ivanklee86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inirudebwoy @FredrikOseberg @coveralls @ivanklee86