Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes docstring ref to default_value argument. #213

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jun 27, 2022

Description

This argument was made obsolete a while ago and makes the client crash
when used.

Based on @sighphyre's comment in Unleash PR 1582.


Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has not been tested yet. It seems like straight forward doc-update to me, but if there are ways to verify it, I'm more than happy to.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This argument was made obsolete a while ago and makes the client crash
when used.
@thomasheartman thomasheartman requested a review from sighphyre June 27, 2022 09:01
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.159% when pulling af592d0 on fix/remove-obsolete-arg into 38959f9 on main.

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@thomasheartman thomasheartman merged commit 3d15865 into main Jun 27, 2022
@thomasheartman thomasheartman deleted the fix/remove-obsolete-arg branch June 27, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants