Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to get features #218

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Add retries to get features #218

merged 3 commits into from
Sep 1, 2022

Conversation

janboll
Copy link
Contributor

@janboll janboll commented Aug 18, 2022

Description

Create session and provide it with a custom HTTPAdapter, that has max_retries set.

Fixes #217

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Create session and provide it with a custom HTTPAdapter, that has max_retries set.

Related issue: Unleash#217
@sighphyre sighphyre self-assigned this Aug 23, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.196% when pulling 45d76eb on janboll:add-retries into 615ca5b on Unleash:main.

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, really appreciate you running with this.

This looks good to me!

@sighphyre sighphyre requested a review from ivanklee86 August 25, 2022 09:19
@ilee-asapp
Copy link

Sorry, I've been on vacation and am slowly catching up with life. >_O

I'll take a peek at the CI/CD failure tonight and cut a release once that's fixed!

@povilasb
Copy link
Contributor

povilasb commented Sep 1, 2022

Thank you!
I'm eagerly waiting for this to be released :)

@ivanklee86 ivanklee86 merged commit c47f071 into Unleash:main Sep 1, 2022
@ivanklee86
Copy link
Collaborator

This PR is in v5.3.0 which is up on Pypi now! :)

@povilasb
Copy link
Contributor

povilasb commented Sep 1, 2022

Would be cool to retry all HTTP requests coming from this lib btw :)
e.g. metrics reporting:

resp = requests.post(url + METRICS_URL,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retries to get_feature_toggles
6 participants