Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude tests from build output #314

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

sighphyre
Copy link
Member

Description

This forces the wheel and tarball builds to exclude the test folder in the output. For two reasons:

  1. This conflicts with end users test files sometimes
  2. I want a reasonable way to exclude sample applications (incoming) from the build output

Type of change

None of the standard options, just a build fix

How Has This Been Tested?

Folder diffing, checked the build outputs and the only change we see is that the tests are excluded and the manifest is patched to reflect this

Checklist:

  • [ x ] I have performed a self-review of my own code
  • [ x ] My changes generate no new warnings
  • [ x ] New and existing unit tests pass locally with my changes

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 97.043%. remained the same
when pulling f59e354 on chore/exclude-tests-from-build
into 568d85b on main.

@sighphyre sighphyre merged commit aab747d into main Jul 1, 2024
43 checks passed
@sighphyre sighphyre deleted the chore/exclude-tests-from-build branch July 1, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants