Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building requires a valid gpg configuration #20

Closed
chriswk opened this issue Jan 2, 2023 · 0 comments · Fixed by #21
Closed

Building requires a valid gpg configuration #20

chriswk opened this issue Jan 2, 2023 · 0 comments · Fixed by #21
Assignees
Labels
bug Something isn't working

Comments

@chriswk
Copy link
Member

chriswk commented Jan 2, 2023

Describe the bug

When building (particularly for PRs) our current maven setup requires a valid gpg/pgp setup in order for the build to sign the artifacts. Signing the artifacts when building/verifying CI seems excessive

Steps to reproduce the bug

  1. Create a PR.
  2. Wait for CI to run
  3. Build fails

Expected behavior

Build succeeds

Logs, error output, etc.

No response

Screenshots

No response

Additional context

Due to how our section in the pom is setup we require the maven gpg plugin to sign all artifacts also when not running with release profile. We should move this to a release profile, to ensure that we only sign artifacts when actually producting something to upload to maven central

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

@chriswk chriswk added the bug Something isn't working label Jan 2, 2023
@chriswk chriswk self-assigned this Jan 2, 2023
@chriswk chriswk mentioned this issue Jan 2, 2023
Merged
chriswk pushed a commit that referenced this issue Jan 2, 2023
This makes sure we only run nexus-staging and gpg plugin when actually
running with the release profile active. We've configured the release
plugin to run with the release profile active when running
release:prepare/release:perform tasks.

Fixes: #20
@chriswk chriswk moved this from New to In Progress in Issues and PRs Jan 2, 2023
praveenpg pushed a commit that referenced this issue Jan 18, 2023
* fix: Add release profile

This makes sure we only run nexus-staging and gpg plugin when actually
running with the release profile active. We've configured the release
plugin to run with the release profile active when running
release:prepare/release:perform tasks.

Fixes: #20

* fix: set to SNAPSHOT version again
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant