docs: fix an issue where it goes into an infinite loop when building #4596
Conversation
This change sets `noRuntimeDownloads` to `true` for `plugin-remote-content'` to avoid the infinite loop issue mentioned in rdilweb/docusaurus-plugin-remote-content#51, as described in https://github.com/rdilweb/docusaurus-plugin-remote-content#noruntimedownloads. I suspect that this will require you to generate the files before running the doc build, which may be an issue. However, this does stop the doc from building over and over.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dgorton Have you had a chance to have a look at this? Have any thoughts? |
dgorton
dismissed
their stale review
Let's get the build documentation as well.
|
Fixing infinite loops is obviously a good thing. It would be nice not to add more steps to the build process, however - especially as this will likely catch people by surprise. Are you comfortable adding these commands as part of the build step, per your comment?
|
|
Yeah, good points. I think it should be pretty straightforward. Should look something like d0d9da8. Let's see if that works. |
This change sets
noRuntimeDownloadstotrueforplugin-remote-content'to avoid the infinite loop issue mentioned inrdilweb/docusaurus-plugin-remote-content#51,
as described in
https://github.com/rdilweb/docusaurus-plugin-remote-content#noruntimedownloads.
Note that this will require you to generate the files before
running the doc build, which may be more an issue, so it's a tradeoff.
To generate the files before building run:
We can of course write a simpler command that does this for us (or even make it part of the build step). In fact, I think we'll need to do exactly that. It seems to be failing now because the files are not generated by default by the build steps.
Creating this PR mostly to get feedback from @dgorton. What do you think?