Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to jest #854

Merged
merged 26 commits into from
May 28, 2021
Merged

Migrate to jest #854

merged 26 commits into from
May 28, 2021

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented May 26, 2021

No description provided.

Christopher Kolstad and others added 23 commits May 27, 2021 23:08
Migrate to jest
1681f81
fix: correct command for running coveralls
860b073
@ivarconr
fix: assertions
261a805
removed lolex and sinon
7a395a5
fix: tweak timer use
ce18602
chore: eslint
145c2a3
fix: destroy timers for announce and bulkAdd
e2ccbff
fix: keep timers for poolMetrics
b50d2d6
@ivarconr
fix: add destroy method for version-service
a5f0cb4
@ivarconr
wip: start introducing app destroy
b652e0d
@ivarconr
fix: all the tests
915e129
@ivarconr
fix: adjust jest options
817b1d6
@ivarconr
fix: await promise
6b03731
Remove unnecessary pause
1304adb
fix: add test:coveralls allowing to run test:coverage locally
eb08f38
fix: make sure more of the tests opening services destroy them
56d785c
@ivarconr
fix: lint
3d61cf6
@ivarconr
fix: tests
3367a85
fix: more destroy calls
d3fc01f
fix: eslint
abd8a61
Use --force-exit until dns close handle is fixed
ecaa53d
Don't run separate coveralls task in npm, use github action
5ee6269
fix: use more explicit jest assertion
1396222
@chriswk chriswk requested a review from ivarconr May 27, 2021 21:12
@coveralls
Copy link

coveralls commented May 27, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-3.9%) to 90.203% when pulling 6617126 on jest into 1d7be17 on master.

ivarconr
ivarconr approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@ivarconr ivarconr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. 🏙️

@chriswk chriswk merged commit 3a65847 into master May 28, 2021
@SimenB SimenB deleted the jest branch September 2, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriswk @coveralls @ivarconr