Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thanks a lot for this radicale plugin. I plan to use it for my own needs. I use it with a SaaS mail provider hosting thousands of emails and domains. Of course, I don't want anyone hosted on this provider to authenticated against my radicale instance.
This is why I implemented another configuration to allow specific email domains only. This was inspired by the Gitea SMTP auth.
auth: allowed_domains = mydomain.tld, your.domain.tld
I took the liberty of adding some unit tests and to do some minor modifications (formatting, gitignore and adding some additionnal debugs)
Hope this pull request can help the community !
(please don't hesitate to critic my code, I'm not a python developer)
Have a great day !