Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Python 3.7 typing imports #108

Merged
merged 3 commits into from
Dec 21, 2022
Merged

fix: Python 3.7 typing imports #108

merged 3 commits into from
Dec 21, 2022

Conversation

cragwolfe
Copy link
Contributor

@cragwolfe cragwolfe commented Dec 21, 2022

Per issue #57 , fix typing imports in Python 3.7.

make test failed before these changes, and now works in a local Python-3.7 venv.

To be fair, getting all the deps installed in a Python-3.7 venv is a bit of pain, but I did that with pip install -e ., multiple calls to pip install -r requirements/___.in, then pip install any remaining missing packages.

Thanks to @firmai for providing a snippet to the fix.

@cragwolfe cragwolfe requested a review from qued December 21, 2022 05:37
@cragwolfe cragwolfe enabled auto-merge (squash) December 21, 2022 05:37
@cragwolfe cragwolfe merged commit 962c9dc into main Dec 21, 2022
@cragwolfe cragwolfe deleted the crag/py-37 branch December 21, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants