Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #57 , fix typing imports in Python 3.7.
make test
failed before these changes, and now works in a local Python-3.7 venv.To be fair, getting all the deps installed in a Python-3.7 venv is a bit of pain, but I did that with
pip install -e .
, multiple calls topip install -r requirements/___.in
, thenpip install
any remaining missing packages.Thanks to @firmai for providing a snippet to the fix.