feat(resource): implement managed database resource types #187
Conversation
aakso
force-pushed
the
feat/managed-databases
branch
from
c2bd158
to
4904bae
Compare
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Optional: true, | ||
| ValidateDiagFunc: func(i interface{}, path cty.Path) diag.Diagnostics { |
There was a problem hiding this comment.
Perhaps this could be replaced with a function from, validation package?
ValidateFunc: validation.StringInSlice([]string{"monday", "tuesday" ...}, false)
| Zone: d.Get("zone").(string), | ||
| } | ||
|
|
||
| if d.HasChange("properties.0") { |
There was a problem hiding this comment.
Perhaps I'm wrong here, but my understanding so far was that create function is called only once for resource. If that's the case - what is the point of checking for changes here?
There was a problem hiding this comment.
yes could be. Anyway, the point is to check if custom properties are requested.
| return diag.FromErr(fmt.Errorf("cannot create a logical database while managed database %v (%v) is powered off", serviceDetails.Name, serviceID)) | ||
| } | ||
|
|
||
| if d.HasChanges("character_set", "collation") && serviceDetails.Type != upcloud.ManagedDatabaseServiceTypePostgreSQL { |
There was a problem hiding this comment.
Again, not really sure about checking for changes in create function. Wouldn't d.GetOk be more suitable here?
There was a problem hiding this comment.
I don't know. AFAIK HasChanges calls GetOk internally.
However, the check is valid as those parameters are only valid for postgres.
There was a problem hiding this comment.
HasChanges compare the previous value with the new one, GetOkonly checks if it's existing and not a zero-value, no?
There was a problem hiding this comment.
@BachirKhiati as said, I'm not entirely sure, the stuff isn't very well documented.
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| ValidateDiagFunc: validateManagedDatabaseLocale, |
There was a problem hiding this comment.
I'm not sure if you need separate function for this, I think something like this would also work:
ValidateFunc: validation.StringMatch(regexp.MustCompile(`someregexp`), "some error msg")
| Sensitive: true, | ||
| Computed: true, | ||
| Optional: true, | ||
| ValidateDiagFunc: func(i interface{}, path cty.Path) diag.Diagnostics { |
There was a problem hiding this comment.
Could probably be also handled by validation.StringLenBetween function
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] managed database user %v/%v (%v/%v) read", |
There was a problem hiding this comment.
Same question about this debug log as above
Wait managed database to be fully created and running before shutdown.
Wait managed database to be running and service name to be propagated before continuing execution. Add UpCloud Managed Databases to CHANGELOG.
peknur
requested review from
BachirKhiati and
ka-myl
and removed request for
ajmyyra
Maintenance window properties were ignored when creating instances and also in updates if only one of two properties (maintenance_window_dow, maintenance_window_time) were changed.
This patch adds initial support for our Managed Databases. Moreover, we switch to importing the major >1 version of UpCloud GO SDK properly.