Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine IP addressing choices #48

Open
scop opened this issue Nov 13, 2024 · 2 comments
Open

Refine IP addressing choices #48

scop opened this issue Nov 13, 2024 · 2 comments

Comments

@scop
Copy link
Member

scop commented Nov 13, 2024

We should refine the IP address choices made available when creating a server.

  • Consider not offering the option to create the Utility IP/interface.
  • Consider removing the addressing option altogether, and always going with either public IPv4 only, or public IPv4+IPv6.
@thevilledev
Copy link

As discussed internally, public IPv4 only for now

@adityawbwce
Copy link
Contributor

adityawbwce commented Nov 19, 2024

Open the lib/ConfigOptions.php file and remove the code between lines # 40 to # 45, which is as follows:
private function getNetworking()

{
    $nw['ipv4only'] = 'Public IPv4 Only';
     $nw['default'] = 'Public Default (IPv4, IPv6 & Utility)';
     return $nw;
 }

Also, remove line #81, which contains the following code within lib/ConfigOptions.php file:
$this->createIPFields($groupId, $this->getNetworking());

Open the lib/vmManager.php file and find the line #69 and replace from
$networking = $this->params['configoptions']['ipaddress'];
to
$networking = "ipv4only";

adityawbwce added a commit to adityawbwce/upcloud-whmcs-module that referenced this issue Nov 19, 2024
 Refine IP addressing choices UpCloudLtd#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants