feat: Add Redis Sentinel connection support #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Redis Sentinel via the following options: - `--url sentinel://:mypass@sentinel.01:26379` - `--sentinelExtraEndpoints sentinel.02:26379 sentinel.03:26379 --` - `--sentinelMasterName myredis`
Add support for `--sentinel-extra-endpoints` and `--sentinel-master-name` via the environment variables: - `EXPORTER_SENTINEL_EXTRA_ENDPOINTS` - `EXPORTER_SENTINEL_MASTER_NAME`
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Redis Sentinel via the following options:
--url sentinel://:mypass@sentinel.01:26379--sentinelExtraEndpoints sentinel.02:26379 sentinel.03:26379 --,--sentinel-extra-endpoints sentinel.02:26379 sentinel.03:26379 --sentinel.03:26379 --`--sentinelMasterName myredis,--sentinel-master-name myredisAdd support of the new configuration options via the environment variables as well:
EXPORTER_SENTINEL_EXTRA_ENDPOINTSEXPORTER_SENTINEL_MASTER_NAMEThis is a
Checklists
Commit style
Changes are on a branch with a descriptive name eg.
fix/missing-queue,docs/setup-guideCommits start with one of
feat:fix:docs:chore:or similarNo excessive commits, eg: there should be no
fix:commits for bugs that existed only on the PR branch (see guide-to-interactive-rebasing)Protected files
The following files should not change unless they are directly a part of your change.
yarn.lock(unless package.json is also modified, then only the new/updated package should be changed here)package.json(renovate bot should handle all routine updates)package-lock.json(Should not exist as this project uses yarn)tsconfig.json(only make it stricter, making it more lenient requires more discussion)tslint.json(only make it stricter, making it more lenient requires more discussion)