Property Migration (Font Branch Diff Preview) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Patch ScaleFactor in reflection database * Adds ScaleFactor via reflection patch * Marks Scale as alias for ScaleFactor * Add custom setter and no getter for Scale Signed-off-by: Dekkonot <git@dekkonot.com> * Set Scriptability of Scale to Custom and implement Getter for it Signed-off-by: Dekkonot <git@dekkonot.com> --------- Signed-off-by: Dekkonot <git@dekkonot.com>
* Implement Font type * Error when not impl future FontStyles * Add docs * Delete old tests * Add new test * Fix formatting consistency issues in spec file Co-authored-by: Micah <dekkonot@rocketmail.com> * Address PR comments * Use explicit from_x and to_x * Derive and use Copy * Nicer default when writing cached_face_id * IgnoreGuiInset no longer saves (replaced by ScreenInsets) * Fix typo in binary.md Co-authored-by: Lucien Greathouse <me@lpghatguy.com> * Fix font weight casing * Remove unused constructor * Fix snapshot tests for PascalCase fonts * Don't cast around u16 for xml * Remote Other for Font Weight and Style * Fix camelCase attribute on FontStyle * Add PR changes to CHANGELOG files * Fix Font types from being excluded * Update database to reflect Font inclusion * Use if...else * Fix minor formatting * to_x -> as_x --------- Co-authored-by: set <set> Co-authored-by: Micah <dekkonot@rocketmail.com> Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
* Add test case * Sort shared strings before assigning ids * Update snapshots * Update changelog * Add xml test * Update test-files submodule
…ojo-rbx#258) * Clean up chunk section + document zstd compression * Document Bytecode data type * List Bytecode in README * Add Bytecode type to table of contents * Remove quotes around `ZSTD "frame"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff preview for rojo-rbx#253 because it's based on the
implement-font-typebranch, notmaster.