Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private field to package manifest #76

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

nezuo
Copy link
Contributor

@nezuo nezuo commented Feb 14, 2022

Closes #9

Copy link
Member

@magnalite magnalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good although it's important this functionality always works after we add it. Could you add a test to ensure we don't regress?

The test should be in tests/integration/publish.rs and you can look at check_prompts_auth() to see what it might look like! You'll also want to make a new project in test-projects with a toml containing private set to true.

@nezuo nezuo requested a review from magnalite February 14, 2022 20:06
Copy link

@ThatTimothy ThatTimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pulled this locally and tested it, everything looks perfectly fine. The test also fails if I remove the bail segment or cause the package to publish anyways, so it looks good to me!


@magnalite Is there any update on this? Just asking because it's been 6 months, and this seems like a ready-to-release feature.

@magnalite magnalite merged commit 668718c into UpliftGames:main Feb 1, 2023
@magnalite magnalite added this to the Essential feature complete milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private field in package manifest
3 participants