Remove rav1e::Frame::new()

It is a big footgun (xiph#2461) and should be avoided.

src/bin/decoder/mod.rs

@@ -16,7 +16,7 @@ pub mod y4m;
 pub trait Decoder {
   fn get_video_details(&self) -> VideoDetails;
   fn read_frame<T: Pixel>(
-    &mut self, cfg: &VideoDetails,
+    &mut self, ctx: &Context<T>, cfg: &VideoDetails,
   ) -> Result<Frame<T>, DecodeError>;
 }
 

src/bin/decoder/y4m.rs

@@ -37,14 +37,13 @@ impl Decoder for y4m::Decoder<Box<dyn Read>> {
   }
 
   fn read_frame<T: Pixel>(
-    &mut self, cfg: &VideoDetails,
+    &mut self, ctx: &Context<T>, cfg: &VideoDetails,
   ) -> Result<Frame<T>, DecodeError> {
     let bytes = self.get_bytes_per_sample();
     self
       .read_frame()
       .map(|frame| {
-        let mut f: Frame<T> =
-          Frame::new(cfg.width, cfg.height, cfg.chroma_sampling);
+        let mut f = ctx.new_frame();
 
         let (chroma_width, _) =
           cfg.chroma_sampling.get_chroma_dimensions(cfg.width, cfg.height);

src/bin/rav1e.rs

@@ -109,7 +109,7 @@ impl<D: Decoder> Source<D> {
       }
     }
 
-    match self.input.read_frame(&video_info) {
+    match self.input.read_frame(ctx, &video_info) {
       Ok(frame) => {
         match video_info.bit_depth {
           8 | 10 | 12 => {}

src/frame/mod.rs

@@ -45,7 +45,7 @@ pub struct FrameParameters {
 pub use v_frame::frame::Frame;
 
 /// Public Trait Interface for Frame Allocation
-pub trait FrameAlloc {
+pub(crate) trait FrameAlloc {
   /// Initialise new frame default type
   fn new(width: usize, height: usize, chroma_sampling: ChromaSampling)
     -> Self;

src/fuzzing.rs

@@ -153,13 +153,8 @@ pub fn fuzz_encode(data: &[u8]) {
   let mut context: Context<u8> = res.unwrap();
 
   let frame_count = g.g::<u8>() % 3 + 1;
+  let mut frame = context.new_frame();
   let frames = (0..frame_count).map(|_| {
-    let mut frame = Frame::new(
-      config.enc.width,
-      config.enc.height,
-      config.enc.chroma_sampling,
-    );
-
     for plane in &mut frame.planes {
       let stride = plane.cfg.stride;
       for row in plane.data_origin_mut().chunks_mut(stride) {
@@ -169,7 +164,7 @@ pub fn fuzz_encode(data: &[u8]) {
       }
     }
 
-    frame
+    frame.clone()
   });
 
   let _ = encode_frames(&mut context, frames);

src/lib.rs

@@ -217,7 +217,7 @@ pub mod prelude {
   pub use crate::api::*;
   pub use crate::encoder::Tune;
   pub use crate::frame::{
-    Frame, FrameAlloc, FrameParameters, FrameTypeOverride, Plane, PlaneConfig,
+    Frame, FrameParameters, FrameTypeOverride, Plane, PlaneConfig,
   };
   pub use crate::partition::BlockSize;
   pub use crate::predict::PredictionMode;