Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please review it. This is the image of changes which i have done in #40. #65

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

please review it. This is the image of changes which i have done in #40. #65

wants to merge 14 commits into from

Conversation

anupriyajain595
Copy link

Screenshot (4)

@UsmanAhmadSaeed
Copy link
Owner

@anupriyajain595 I'll review and update.

@anupriyajain595
Copy link
Author

Okay sir

@DevKosov
Copy link
Collaborator

Please read our rules and guidelines before adding an animation.

Our rules specify that the animation has to be from pure HTML, CSS, JS and not any other framework but GSAP.

You're using Typed. It would be a really good JavaScript challenge to remove the framework and try to recreate the same thing.

@anupriyajain595
Copy link
Author

Sir i have removed the framework so please review it.

@UsmanAhmadSaeed
Copy link
Owner

@anupriyajain595 please add comments and follow coding best practices. Please take a look at all our guidelines before next commit. Also, I've added the hacktoberfest accepted label so don't worry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
against guidelines hacktoberfest-accepted pending approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anupriyajain595 @UsmanAhmadSaeed @DevKosov