Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read meta #1

Closed
wants to merge 7 commits into from
Closed

Read meta #1

wants to merge 7 commits into from

Conversation

chStaiger
Copy link
Member

No description provided.

@chStaiger chStaiger requested a review from qubixes July 15, 2024 12:12
qubixes
qubixes requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@qubixes qubixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a nice start. Are you planning to merge this soon or still waiting for more changes?

data/metadata_test/_validation_schema.toml Show resolved Hide resolved
src/check_data.py Show resolved Hide resolved
src/check_data.py Show resolved Hide resolved
@chStaiger chStaiger marked this pull request as ready for review July 18, 2024 13:45
qubixes
qubixes approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@qubixes qubixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! We can modify things in other PRs, I think this is good enough for now!

@lagerweijgr
Copy link
Collaborator

With some delay, i approve

@chStaiger
Copy link
Member Author

Replaces by #6

@chStaiger chStaiger closed this Sep 13, 2024
@chStaiger chStaiger deleted the read-meta branch October 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qubixes qubixes qubixes approved these changes

@lagerweijgr lagerweijgr Awaiting requested review from lagerweijgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chStaiger @lagerweijgr @qubixes