Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_ticket argument obj_path is unclear #231

Closed
qubixes opened this issue Jul 18, 2024 · 1 comment · Fixed by #249
Closed

create_ticket argument obj_path is unclear #231

qubixes opened this issue Jul 18, 2024 · 1 comment · Fixed by #249
Assignees
@chStaiger
Milestone
v1.1

Comments

@qubixes
Copy link
Collaborator

qubixes commented Jul 18, 2024

The create_ticket function takes an obj_path argument, which is confusing since it can also take paths to collections. We should also support IrodsPath's as an argument.
@qubixes qubixes added this to the v1.2 milestone Jul 18, 2024
@chStaiger chStaiger self-assigned this Jul 22, 2024
@chStaiger
Copy link
Member

Agreed. I think it is just the variable name that is confusing here. I will test how the function behaves with collections and then move to IrodsPath!

@chStaiger chStaiger linked a pull request Aug 16, 2024 that will close this issue
Switch to IrodsPath, rename function #249
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chStaiger chStaiger

Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Switch to IrodsPath, rename function UtrechtUniversity/iBridges
2 participants
@chStaiger @qubixes