Check for md5 checksums if remote uses that #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chStaiger
reviewed
Aug 18, 2024
ibridges/util.py
Outdated
| memv=memoryview(bytearray(128*1024)) | ||
| with open(filepath, 'rb', buffering=0) as file: | ||
| for item in iter(lambda : file.readinto(memv), 0): | ||
| f_hash.update(memv[:item]) | ||
| if checksum_type == "md5": | ||
| return f"md5:{f_hash.hexdigest()}" |
There was a problem hiding this comment.
The native iRODS checksum in the iCAT not use the prefix md5: but just returns the md5sum. So will this work?
There was a problem hiding this comment.
Well, no then it's not going to work. Can we test md5 checksums on both YoDa and the native iRODS integration test?
ibridges/util.py
Outdated
|
|
||
| """ | ||
| remote_check = calc_checksum(remote_path) | ||
| local_check = calc_checksum(local_path, checksum_type=remote_check.split(":")[0]) |
There was a problem hiding this comment.
Ah, now I see. You are introducing the md5: prefix to unify the code for the two checksum types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245