Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fact_regular_users: install jmespath dependency in venv #191

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

dometto
Copy link
Member

@dometto dometto commented Aug 5, 2024

Pilot version of SRC-External now uses ansible in a bench, but our fact_regular_users role installs the jmespath dependency globally, and not in the venv.

@dometto
Copy link
Member Author

dometto commented Aug 6, 2024

Waiting to merge this until there is more clarity on what the new SRC-External component will do exactly. (These changes are based on the current main branch of that component, but it may change before it goes live)

@dometto dometto marked this pull request as draft September 18, 2024 08:08
@dometto dometto marked this pull request as ready for review September 23, 2024 13:58
@dometto dometto force-pushed the fix/190 branch 4 times, most recently from 46820e5 to fb3ad22 Compare September 23, 2024 14:46
@dometto dometto closed this Sep 23, 2024
@dometto dometto reopened this Sep 23, 2024
@dometto dometto merged commit a20effe into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant