Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license #7

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Add license #7

merged 3 commits into from
Sep 5, 2023

Conversation

kequach
Copy link
Contributor

@kequach kequach commented Sep 14, 2022

As discussed in #5, this PR adds a license to this repository. The license has been discussed with Erwin Leufkens, art director at UU.

@jkorb
Copy link
Collaborator

jkorb commented Nov 9, 2022

Sorry it took me forever to get back to this for research reasons. I'm now hoping to get this merge finished soon. So:

First of all, looks great! Thanks so much for doing this. Three things:

  • There are small wording differences in the license and the MIT license I find on Wikipedia. Here's the diff:

     < use, copy, modify, merge, publish, and/or distribute, and to permit persons to
     < whom the Software is furnished to do so, subject to the following conditions:
     ---
     > use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
     > of the Software, and to permit persons to whom the Software is furnished to do
     > so, subject to the following conditions:
    

    Is this intentional? I'm not sure which license is authorative.

  • We should update the preambles of each class to reflect this (update the year and that we're now covered by MIT). The preamble of the new uubeamer class (:1st_place_medal:) can be an example. It'd be great if we could take care of this in this PR. Would you mind updating the files?

  • While you're at it, we can then delete the license file from the scripts folder, since it's automatically covered by this.

  • Finally, we should probably add something about the copyrights of the pictures and logos. I.e. make clear that only the software is covered by the license. Perhaps a README.md in lib/resources/? Thoughts?

If you can't get around to doing these things, just let me know and I'll try next week. For this week, I'm all LaTeX'ed out after finishing the `uubeamer`` class :)

@kequach
Copy link
Contributor Author

kequach commented Nov 9, 2022

Hi @jkorb, no worries about the response time. Yes, the wording differences are intentional, it's a modified MIT license. I'm not quite sure how to best describe this in the files, maybe something like MIT (modified)? I also asked @J535D165 for some thoughts about this.
I updated and deleted the files according to the 2 bullet points. Regarding the pictures and logos, I think that is a good idea. However, I don't know anything about licensing for these. @J535D165 do you have a suggestion?

@jkorb
Copy link
Collaborator

jkorb commented Nov 10, 2022

Awesome, thanks @kequach ! So, if I understand correctly, you guys took out the sublicensing and selling parts of MIT. Fair. But I guess, it's a mistake, then, to reference this as MIT, as I did in the uubeamer class.

In principle, I'm cool with using a modified MIT as you suggest, I'm just a bit worried about confusions that may arise from using a non-standard license. Have you guys thought about that?

Might be a curveball, and perhaps best be ignored, but if we want to exclude commercial use (not that that'll be an issue), why don't we go with some standard non-commercial license, like the LaTeX license: https://www.latex-project.org/lppl/

I like MIT for its simplicity and because I personally don't care much about what people do with my work, I'm just happy if it helps. But that advantage, simplicity, might be lost by modyfying.

jkorb added a commit that referenced this pull request Nov 10, 2022
We cannot accurately describe license envisioned in
#7 as an MIT license.
@kequach
Copy link
Contributor Author

kequach commented Nov 10, 2022

I agree with the issues in using a modified license. It also makes it difficult to immediately understand what was modified. In that case I'd wait for a response from @J535D165, as he was the one who aligned this with Erwin Leufkens.

@jkorb
Copy link
Collaborator

jkorb commented Nov 11, 2022

Fair! Let's see what he says :)

@J535D165
Copy link
Member

Thanks for catching up with this PR. Interesting discussion! Yes, indeed, I was in contact with the head of branding. The result is this modified MIT license. However, after some thinking, I might want to propose something else first.

The MIT license is a very applicable license for software packages as it is simple, permissive, and easy to understand. There are 2 "musts" for this license: Include the copyright and the license.

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

This is not a big deal in most software applications, as most software is added as a dependency and not shipped with the application. In your case, most users will substantially reuse your work. Therefore, formally (as far as I know, no legal advice), your users should include the copyright and a copy of the license in their project/report.

I suggest releasing all YOUR work under a CC0 or Unlicense (public domain). Then, users can use it without concerns about the license and including the copyright/license, and you are not responsible for any damage. Of course, the user must adhere to the copyright for the branding. But this is less confusing than having these two "licenses" or the combined version proposed in this PR.

You might want some credits for your work as well :) In that case, it would be nice to add your name on the last slide of the beamer and somewhere on the report template. I think that will have more impact in terms of credits than having a copy of the MIT license included in someone's project/report. See also this interesting blog https://blog.datadryad.org/2011/10/05/why-does-dryad-use-cc0/.

(This might also be interesting: https://creativecommons.org/2011/04/15/using-cc0-for-public-domain-software/)

@jkorb
Copy link
Collaborator

jkorb commented Nov 16, 2022

Great that you're chiming in, @J535D165 ! And thanks for hashing this out with Erwin.

I'm cool with publishing my templates under CC0. As I said, I'm not really keen on recognition and like to keep things simple. So public domain sounds like a good idea :) And if I understand correctly, this should be cool with Erwin/the Corporate Identity department, since it just covers the code and not the branding it implements, right?

So, how would we realize this: CC0 license disclaimer everywhere together with the existing copyright disclaimers about the branding? I would also put my name, email, and a link to this repo in there, not for copyright reasons but so that people can find the most recent version.

Do we need to double check this with Erwin?

Once the copyright issue is solved, I'll be looking into packaging this into an official release for ease of use.

@jkorb jkorb linked an issue Nov 24, 2022 that may be closed by this pull request
@jkorb
Copy link
Collaborator

jkorb commented Aug 30, 2023

Hi @J535D165 and @tymees ! I'm really sorry that this fizzled, but I'm keen on picking this back up. Are you still around? So, my favorite option would be CC0 as mentioned. The only open questioin would be whether this needs to be checked with Erwin.

@tymees
Copy link
Contributor

tymees commented Aug 30, 2023

Not entirely sure why you've mentioned me, my only contribution here is so small I doubt it would even be eligible for copyright ;)

Anyway, CC0 looks fine for my one-word-change ;)

Just to weigh in on the branding stuff;
First of, I am not a lawyer, I'm just parroting someone I consulted when my team ran into pretty much the same situation in a different UU-branding related project.

A lot of the branding is (also) protected by trademark law, which the license does not cover. So, there is additional protection there for the branding. (In addition to other copyright related stuff that might still be applicable, as the license should indeed cover the code itself only).

@J535D165
Copy link
Member

Agreed. There is no need to check this with Erwin. The contact I had with him should be fine.

Update this PR to CC0?

@jkorb
Copy link
Collaborator

jkorb commented Aug 31, 2023

Sorry, @tymees ! Tagging suggestions confused me, but that's very valuable input, so thanks for that!

I meant to tag @kequach , since this is his PR/initiative.

@J535D165 : awesome, thanks! Yes, let's move to CC0.

@kequach can you update the PR (if you're still interested)? Otherwise, I can take care of it this week.

@kequach
Copy link
Contributor Author

kequach commented Aug 31, 2023

Hi @jkorb I can take a look later this week. If you get to it before me, feel free to take over 👍

@kequach
Copy link
Contributor Author

kequach commented Sep 2, 2023

@jkorb please have a look if the changes are fine and feel free to make any suggestions

@jkorb
Copy link
Collaborator

jkorb commented Sep 2, 2023

Awesome, thanks so much!! I'll go through this tomorrow!

@kequach
Copy link
Contributor Author

kequach commented Sep 2, 2023

I didn't do that much but you're welcome 😀

@jkorb
Copy link
Collaborator

jkorb commented Sep 4, 2023

Hi @kequach @J535D165 (and @tymees ). I've updated the PR to follow the recommendations on using CC0 for software by the CC-peeps (https://wiki.creativecommons.org/wiki/CC0_FAQ#May_I_apply_CC0_to_computer_software.3F_If_so.2C_is_there_a_recommended_implementation.3F). I'd be cool with merging this now. Does anybody want to have a second look? Would be awesome for my peace of mind :)

@kequach
Copy link
Contributor Author

kequach commented Sep 4, 2023

Hi @jkorb , I will have a look sometime this week

@jkorb
Copy link
Collaborator

jkorb commented Sep 4, 2023

Thanks, @kequach !


This software was originally written by Johannes Korbmacher
([j.korbmacher@uu.nl](mailto:j.korbmacher@uu.nl)) and contains contributions
from Ty Mees ([t.d.mees@uu.nl](mailto:t.d.mees@uu.nl)) and Kevin Quach.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from Ty Mees ([t.d.mees@uu.nl](mailto:t.d.mees@uu.nl)) and Kevin Quach.
from Ty Mees ([t.d.mees@uu.nl](mailto:t.d.mees@uu.nl)) and Keven Quach.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, sorry for mispelling your name. I wasn't paying due dilligence!

COPYING Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to keep the file name as "LICENSE", since this allows GitHub to automatically detect the license. COPYING is not a machine-readable file name on GitHub, even though CC0 recommends this naming.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good to know. Let's go with that.

@kequach
Copy link
Contributor Author

kequach commented Sep 4, 2023

I added two remarks. Besides that, I think we are ready to merge @jkorb

@jkorb
Copy link
Collaborator

jkorb commented Sep 5, 2023

I added two remarks. Besides that, I think we are ready to merge @jkorb

Awesome! Thanks so much, @kequach for starting this and @J535D165 , @tymees for chiming in.

If you're OK with that, @kequach , I'll reorder some commits and push --force to this PR/your fork's main branch. This would be a horrible idea if you have local work on the repo on your computer, but I assume you don't, right? If you don't have local work, it would be great if I could re-order and better document some of the commits in this way :)

@kequach
Copy link
Contributor Author

kequach commented Sep 5, 2023

I added two remarks. Besides that, I think we are ready to merge @jkorb

Awesome! Thanks so much, @kequach for starting this and @J535D165 , @tymees for chiming in.

If you're OK with that, @kequach , I'll reorder some commits and push --force to this PR/your fork's main branch. This would be a horrible idea if you have local work on the repo on your computer, but I assume you don't, right? If you don't have local work, it would be great if I could re-order and better document some of the commits in this way :)

Feel free to go ahead!

jkorb and others added 3 commits September 5, 2023 09:03
We've decided to move to "unlicense"/CC0 the classes and the new
copyright notices are based on the suggestions by the Creative Commons
organization for how to do that.

For details, see
https://creativecommons.org/share-your-work/public-domain/cc0/

and, in particular, the suggestions concerning software in the FAQ:

https://wiki.creativecommons.org/wiki/CC0_FAQ#May_I_apply_CC0_to_computer_software.3F_If_so.2C_is_there_a_recommended_implementation.3F

Co-authored-by: Keven Quach <belfami@gmail.com>
We've decided to move to "unlicense"/CC0 the classes and the new
copyright notices are based on the suggestions by the Creative Commons
organization for how to do that.

For details, see
https://creativecommons.org/share-your-work/public-domain/cc0/

and, in particular, the suggestions concerning software in the FAQ:

https://wiki.creativecommons.org/wiki/CC0_FAQ#May_I_apply_CC0_to_computer_software.3F_If_so.2C_is_there_a_recommended_implementation.3F

Co-authored-by: Keven Quach <belfami@gmail.com>
We've decided to move to "unlicense"/CC0 the classes and the new
copyright notices are based on the suggestions by the Creative Commons
organization for how to do that.

For details, see
https://creativecommons.org/share-your-work/public-domain/cc0/

and, in particular, the suggestions concerning software in the FAQ:

https://wiki.creativecommons.org/wiki/CC0_FAQ#May_I_apply_CC0_to_computer_software.3F_If_so.2C_is_there_a_recommended_implementation.3F

Even though CC0 is not a license, we've included the text in
```LICENSE``` because GitHub reads this file. This is why we decided
against the advice of the CC to call the file (more appropriately)
```COPYING```.

Co-authored-by: Keven Quach <belfami@gmail.com>
@jkorb jkorb merged commit 3a9d699 into UtrechtUniversity:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License missing
4 participants