Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Commit

Permalink
refactor: update less to v3 to avoid all the deprecation warnings (#7)
Browse files Browse the repository at this point in the history
Co-authored-by: Sai <sai@pelago.com.sg>
  • Loading branch information
SaiCharanMahadevan and Sai committed May 8, 2020
1 parent 2795d39 commit 80a6422
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions packages/react-scripts/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,10 @@ module.exports = function(webpackEnv) {
// variable overrides for antd default less variables
// https://github.com/ant-design/ant-design/blob/master/components/style/themes/default.less
modifyVars: themeVariables,
// Potential risk allowing inline js -> https://stackoverflow.com/a/50686643/13430933
// However, this is required to support antd on less@^3.x.x unless we write our own plugins
// to expose the same
javascriptEnabled: true,
}
),
// Don't consider CSS imports dead code even if the
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"jest-environment-jsdom-fourteen": "1.0.1",
"jest-resolve": "24.9.0",
"jest-watch-typeahead": "0.4.2",
"less": "2.7.3",
"less": "^3.11.1",
"less-loader": "^5.0.0",
"less-vars-to-js": "^1.3.0",
"mini-css-extract-plugin": "0.9.0",
Expand Down

0 comments on commit 80a6422

Please sign in to comment.